Added language option in github api

sirfoga · Aug 18, 2017 · ac8adbb · ac8adbb
1 parent b98b374
commit ac8adbb
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,8 +4,8 @@ All notable changes to this project will be documented in this file.
 
 ### 4.6.3
 
-### 
-
+### Added
+- language option in github api
 
 ### 4.6.2
 

diff --git a/hal/internet/github.py b/hal/internet/github.py
@@ -102,19 +102,24 @@ def __init__(self, api_type):
         super(GithubApi, self).__init__(GithubApi._API_URL_TYPE[api_type])
 
     @staticmethod
-    def get_trending_daily():
+    def get_trending_daily(lang=""):
         """
+        :param lang: str
+            Coding language
         :return: []
             List of GithubUserRepository
         """
 
-        url = "https://github.com/trending?since=daily"
+        url = "https://github.com/trending/"
+        url += str(lang).lower().replace(" ", "") + "?since=daily"
         api_content_request = urllib.request.Request(url)
         api_content_response = urllib.request.urlopen(
             api_content_request).read().decode("utf-8")  # parse response
         soup = BeautifulSoup(api_content_response, "lxml")  # html parser
-        raw_repo_list = soup.find_all("ol", {"class": "repo-list"})[
-            0].find_all("li")
+        raw_repo_list = soup.find(
+            "ol", {"class": "repo-list"}
+        ).find_all("li")
+
         repos_list = []
         for repo in raw_repo_list:
             details = repo.find_all("div")[0].a.text.split("/")