-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve code #252
Improve code #252
Conversation
zdenop
commented
Mar 27, 2021
- improvement of python style
- improved docs
- drop support of outdated version of python and tesseract
these are initial steps for automatic creating of windows packages (maybe other platforms too) |
any comments on this? |
What's the reason behind dropping 3.04 support? |
outdated, not maintained and not already several years unsupported version? |
True but it costs us nothing to keep supporting it just in case there are certain environments with an older tesseract version outside of the user's control (for example). |
IMO this would be very strange situation that user can use the latest python module but has to use old unsupported library (16 Feb 2016). BTW: why not 3.05.02 (released in 19 Jun 2018) that has a lot of fixes? |
I agree with you but, believe it or not, it's still possible to have such a situation. The fact that it doesn't affect our code-base at all makes it an unnecessary change for us and potentially an unnecessary inconvenience for some users, that's why I prefer not to make this change. |
As I wrote - it is up to you. You can cherry-pick commits, or merge PR and then revert that one. |