Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code #252

Closed
wants to merge 7 commits into from
Closed

Improve code #252

wants to merge 7 commits into from

Conversation

zdenop
Copy link
Contributor

@zdenop zdenop commented Mar 27, 2021

  • improvement of python style
  • improved docs
  • drop support of outdated version of python and tesseract

@zdenop
Copy link
Contributor Author

zdenop commented Mar 27, 2021

these are initial steps for automatic creating of windows packages (maybe other platforms too)

@zdenop
Copy link
Contributor Author

zdenop commented Apr 5, 2021

any comments on this?

@sirfz
Copy link
Owner

sirfz commented Apr 19, 2021

What's the reason behind dropping 3.04 support?

@zdenop
Copy link
Contributor Author

zdenop commented Apr 19, 2021

outdated, not maintained and not already several years unsupported version?

@sirfz
Copy link
Owner

sirfz commented Apr 19, 2021

True but it costs us nothing to keep supporting it just in case there are certain environments with an older tesseract version outside of the user's control (for example).

@zdenop
Copy link
Contributor Author

zdenop commented Apr 19, 2021

IMO this would be very strange situation that user can use the latest python module but has to use old unsupported library (16 Feb 2016). BTW: why not 3.05.02 (released in 19 Jun 2018) that has a lot of fixes?
Anyway it is up to you. Soon there will be version 5.

@sirfz
Copy link
Owner

sirfz commented Apr 20, 2021

I agree with you but, believe it or not, it's still possible to have such a situation. The fact that it doesn't affect our code-base at all makes it an unnecessary change for us and potentially an unnecessary inconvenience for some users, that's why I prefer not to make this change.

@zdenop
Copy link
Contributor Author

zdenop commented Apr 20, 2021

As I wrote - it is up to you. You can cherry-pick commits, or merge PR and then revert that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants