Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix API usage examples #261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bertsky
Copy link
Contributor

@bertsky bertsky commented Jul 3, 2021

(sorry for the noise, shouldn't have tried to rename my branches while the PR was open – that closed them!)

revival of #260 (all comments there still apply)

@sirfz
Copy link
Owner

sirfz commented Jul 3, 2021

Hi @bertsky, thank you for taking the time into enhancing the API examples code.

I just want to mention that these examples were a rough translation of tesseract's own API examples. You can see, for example, tesseract's GetComponentImages example which you changed to output something different than the original.

I'd like to keep these examples faithful to the original but if you think some code is no longer relevant/needs correction then we can go ahead with these changes. Perhaps we can provide a separate document with more advanced/detailed examples?

@richardhundt
Copy link

richardhundt commented Jul 1, 2022

For what it's worth, @bertsky pointing out the inconsistency between BoundingBox and SetRectangle way of describing the coordinates has solved the segfaults I've been getting, so this piece of documentation saved my day (I expected to be able to do api.SetRectangle(it.BoundingBox(...)) which blows up in tesseract::HistogramRect)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants