-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add github-workflow building wheels #318
Conversation
affa08f
to
4f959bf
Compare
4f959bf
to
2f5d914
Compare
@zdenop i think i addressed all your review comments now. |
446360b
to
4f47f77
Compare
I like your build scripts, but I am not sure if there should be part of tesserocr. Especially if not experienced user would use them.
|
Regarding GitHub action part - this something I love to see in tesserocr (with windows wheels - but that is more difficult part). |
first off: thanks for taking the time to look at this.
as they are only intended to be used for the wheel builds in ci, we could move them to
do i understand this correctly, that these points are only relevant when users would attempt to use the build-scripts locally?
do i get this right: you're suggesting to compile tesseract with
do i get this right: you're suggesting to to compile leptonic with |
For building release wheels use tesseract and leptonica provided by system. If you plan to introduce testing CI (e.g. for commits, PR) then integrate those scripts to github actions as tesseract and leptonica do.
yes
yes. |
4f47f77
to
f917a4a
Compare
so i just pushed changes doing the following:
is there anything left for me to do here to get this merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, thank you for taking the time to do this. Awaiting @zdenop's approval before merging
@sirfz thanks for merging. quick question: when can we expect the wheels to be available on pypi? |
hi @betaboon, I'll include the wheels with the next release as I can't modify an existing release on pypi |
do you have any idea when that might be ? |
resolves #123
Hello.
This PR adds a github-workflow to create wheels containing all the required libraries.
builds include:
This now builds
leptonica
andtesseract
from source.some further information tho:since
tesseract
andleptonica
are being installed viayum
(formanylinux
),apk
(formusllinux
) andbrew
(formacos
) all of the built wheels contain a different version of tesseract.that might pose a problem to some.
i think the only way to get around that would be to compile tesseract from source.