Fix Scrutinizer-reported issues

src/Behaviour/SoftDelete.php

@@ -4,6 +4,8 @@
 namespace Sirius\Orm\Behaviour;
 
 use Sirius\Orm\Action\ActionInterface;
+use Sirius\Orm\Action\BaseAction;
+use Sirius\Orm\Action\Delete;
 use Sirius\Orm\Mapper;
 use Sirius\Orm\Query;
 
@@ -25,12 +27,12 @@ public function getName()
         return 'soft_delete';
     }
 
-    public function onDelete(Mapper $mapper, ActionInterface $delete)
+    public function onDelete(Mapper $mapper, Delete $delete)
     {
         return new \Sirius\Orm\Action\SoftDelete($mapper, $delete->getEntity(), ['deleted_at_column' => $this->column]);
     }
 
-    public function onNewQuery(Mapper $mapper, Query $query)
+    public function onNewQuery(/** @scrutinizer ignore-unused */Mapper $mapper, Query $query)
     {
         $query->setGuards([
             $this->column => null

src/Behaviour/Timestamps.php

@@ -31,7 +31,7 @@ public function getName()
         return 'timestamps';
     }
 
-    public function onSave(Mapper $mapper, ActionInterface $action)
+    public function onSave(/** @scrutinizer ignore-unused */Mapper $mapper, ActionInterface $action)
     {
         if ($action instanceof Insert) {
             if ($this->createColumn) {

src/Collection/Collection.php

@@ -26,7 +26,8 @@ public function __construct(array $elements = [], callable $castingFunction = nu
 
     protected function castElement($data)
     {
-        return $this->castingFunction ? $this->castingFunction($data) : $data;
+        $castFunction = $this->castingFunction;
+        return $castFunction ? call_user_func($castFunction, $data) : $data;
     }
 
     public function add($element)

src/ConnectionLocator.php

@@ -3,8 +3,6 @@
 
 namespace Sirius\Orm;
 
-use Atlas\Pdo\Connection;
-
 class ConnectionLocator extends \Atlas\Pdo\ConnectionLocator
 {
     public static function new(...$args)

src/Entity/GenericEntityHydrator.php

@@ -10,7 +10,7 @@
 class GenericEntityHydrator implements HydratorInterface
 {
     /**
-     * @var $castingManager
+     * @var CastingManager
      */
     protected $castingManager;
 

src/Query.php

@@ -135,9 +135,12 @@ public function paginate($perPage, $page): PaginatedCollection
         return $this->mapper->newPaginatedCollectionFromRows($this->fetchAll(), $total, $perPage, $page, $this->load);
     }
 
-    public function chunk($count, $callback)
+    /**
+     * @todo implement this feature
+     */
+    /*public function chunk($count, $callback)
     {
-    }
+    }*/
 
     public function count()
     {

src/Relation/Aggregate.php

@@ -11,6 +11,19 @@
 
 class Aggregate
 {
+    /**
+     * @var string
+     */
+    protected $name;
+    /**
+     * @var Relation
+     */
+    protected $relation;
+    /**
+     * @var array
+     */
+    protected $options;
+
     public function __construct(string $name, Relation $relation, array $options)
     {
         $this->name = $name;
@@ -50,7 +63,6 @@ public function attachLazyAggregateToEntity(EntityInterface $entity, Tracker $tr
 
     public function attachAggregateToEntity(EntityInterface $entity, array $results)
     {
-        $keys = $this->relation->getKeyPairs();
         $found = null;
         foreach ($results as $row) {
             if ($this->entityMatchesRow($entity, $row)) {

src/Relation/HasAggregates.php

@@ -40,4 +40,6 @@ public function getAggregates()
 
         return $this->aggregates;
     }
+
+    abstract public function getOption($name);
 }

src/Relation/ManyToMany.php

@@ -111,7 +111,6 @@ private function addPivotColumns($query)
 
     public function joinSubselect(Query $query, string $reference)
     {
-        $tableRef  = $this->foreignMapper->getTableAlias(true);
         $subselect = $query->subSelectForJoinWith()
                            ->from($this->foreignMapper->getTable())
                            ->columns($this->foreignMapper->getTable() . '.*')
@@ -194,7 +193,6 @@ public function detachEntities(EntityInterface $nativeEntity, EntityInterface $f
     protected function addActionOnDelete(BaseAction $action)
     {
         $nativeEntity       = $action->getEntity();
-        $nativeEntityKey    = $nativeEntity->getPk();
         $remainingRelations = $this->getRemainingRelations($action->getOption('relations'));
 
         // no cascade delete? treat as save so we can process the changes
@@ -220,7 +218,6 @@ protected function addActionOnSave(BaseAction $action)
     {
         $remainingRelations = $this->getRemainingRelations($action->getOption('relations'));
 
-        /** @var Collection $foreignEntities */
         $foreignEntities = $this->nativeMapper->getEntityAttribute($action->getEntity(), $this->name);
         if (! $foreignEntities) {
             return;

src/Relation/OneToMany.php

@@ -47,7 +47,6 @@ public function getQuery(Tracker $tracker)
 
     public function joinSubselect(Query $query, string $reference)
     {
-        $tableRef = $this->foreignMapper->getTableAlias(true);
         $subselect = $query->subSelectForJoinWith()
                            ->columns($this->foreignMapper->getTable() . '.*')
                            ->from($this->foreignMapper->getTable())

tests/BaseTestCase.php

@@ -3,7 +3,7 @@
 
 namespace Sirius\Orm\Tests;
 
-use Atlas\Pdo\Connection;
+use Sirius\Orm\Connection;
 use PHPUnit\Framework\TestCase;
 use Sirius\Orm\ConnectionLocator;
 use Sirius\Orm\Orm;