Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate "print..." methods, rename to respective "format..." counterparts #38

Open
Godin opened this issue Jan 3, 2012 · 3 comments

Comments

@Godin
Copy link

Godin commented Jan 3, 2012

From a user point of view : I expect that methods, whose name starts with "print" ( e.g. ParseTreeUtils.printNodeTree ), would really print something to standard output, whereas this is not the case. So maybe would be better to rename them into something like "toString..." or "format..." ?

@sirthias
Copy link
Owner

I agree, "format..." would probably have been a better name.
However, I don't think the benefit of breaking existing code just for this name change is worthwhile...

@Godin
Copy link
Author

Godin commented Jan 10, 2012

Why not simply introduce new methods, but keep previous for the several releases with annotation deprecated, so to let users migrate ?

@sirthias
Copy link
Owner

Alright.
Thanks for raising the issue!

@sirthias sirthias reopened this Jan 11, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants