New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup release through sbt-github-actions and sbt-ci-release #431
Setup release through sbt-github-actions and sbt-ci-release #431
Conversation
matrix: | ||
os: [ubuntu-latest] | ||
scala: [3.2.2] | ||
java: [temurin@8] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incase its not clear, this determines the JDK version when making a release (which in this case is JDK 8)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Ok, you got me. |
Thank you, Matthew, once again for the top-notch description of everything around this PR! |
No worries I just checked the publish action at https://github.com/sirthias/parboiled2/actions/runs/4354999485/jobs/7611152727 and it failed with a gpg signing error. Did you by any chance to forget to Base64 your PGP secret? |
Hmm... nope.
Looks weird.... |
So I think this is relevant sbt/sbt-ci-release#95 |
I'll try again.... |
I found the issue, there is an ancient version of sbt-gpg still in |
@mdedetrich Something went wrong here, apparently in the later stages of the release process: Do you have any idea as to the cause? |
This seems to be it xerial/sbt-sonatype#103 (comment). Ill create a PR, in the meantime can you delete the tag on |
Ah, good, thank you! |
This PR sets up the project so that to make a proper release you only need to push a tag (i.e. for the next release you would push a tag named
v2.4.2
) and everything else is handled, i.e. a github action will trigger that will build and publish the entire project using JDK 1.8. Additionally snapshots will also be made whenever a PR is merged tomaster
.One thing that works slightly differently is the
version
. As you may have noticedversion.sbt
is deleted, this is because sbt-ci-release uses sbt-dynver to generate the version of the project automatically via git tags. In more detail, if the current git status is as at a tag you will get the full version (i.e.v2.4.1
) however if your current git status is not at a tag then sbt-dynver will automatically create a snapshot version based on the current git commit hash while using the last git tag as the base version, i.e. here is an exampleThe only thing you need to do is to add all of the sonatype/PGP related details as github secrets, see https://github.com/sbt/sbt-ci-release#secrets for a comprehensive guide. If you add the github secrets before merging this PR then you can confirm that release will work as it will trigger a snapshot release.