Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide non-self-contained tests behind tag (or sth) #38

Open
sirthias opened this issue Mar 18, 2018 · 0 comments
Open

Hide non-self-contained tests behind tag (or sth) #38

sirthias opened this issue Mar 18, 2018 · 0 comments

Comments

@sirthias
Copy link
Owner

so the regular test command doesn't run them and is properly green.
@sirthias sirthias mentioned this issue Mar 18, 2018
Merged
note added a commit to note/scala-ssh that referenced this issue Oct 24, 2019
@note
Tests being run against dockerized sshd
c438214 
That enables running SshClientSpec on CI and also make it easier to run this test locally as it does not require
any local setup any more.

Solves sirthias#42, at least on code side, @sirthias would need to enable travis on
project settings to make it effective

Related to sirthias#38 - while this PR does not fix exactly this issue it may enable
what was the motivation behind sirthias#38
note added a commit to note/scala-ssh that referenced this issue Oct 24, 2019
@note
Tests being run against dockerized sshd
e265f3a 
That enables running SshClientSpec on CI and also make it easier to run this test locally as it does not require
any local setup any more.

Solves sirthias#42, at least on code side, @sirthias would need to enable travis on
project settings to make it effective

Related to sirthias#38 - while this PR does not fix exactly this issue it may enable
what was the motivation behind sirthias#38
note added a commit to note/scala-ssh that referenced this issue Oct 24, 2019
@note
Tests being run against dockerized sshd
a83bce7 
That enables running SshClientSpec on CI and also make it easier to run this test locally as it does not require
any local setup any more.

Solves sirthias#42, at least on code side, @sirthias would need to enable travis on
project settings to make it effective

Related to sirthias#38 - while this PR does not fix exactly this issue it may enable
what was the motivation behind sirthias#38
@note note mentioned this issue Oct 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sirthias