Fix travis build #52
Fix travis build #52
Conversation
Seems like sbt 1.3.3 changed resolution mechanism and we by bumping up sbt we downgraded sshj Downgrading sbt to 1.2.8 fixes that issue
| @@ -49,5 +50,5 @@ abstract class ScpTransferable { | |||
| def download(remotePath: String, localPath: String)(implicit l: TransferListener = defaultListener): Try[Unit] = | |||
| fileTransfer(_.download(remotePath, localPath))(l) | |||
|
|
|||
| private def defaultListener = new LoggingTransferListener | |||
| private def defaultListener = new LoggingTransferListener(LoggerFactory.DEFAULT) | |||
There was a problem hiding this comment.
The fact that downgrading sbt caused that scala file to not compile any more is a proof that resolution mechanism has changed between sbt 1.2.8 and 1.3.3
| @@ -1 +1 @@ | |||
| sbt.version=1.3.3 | |||
There was a problem hiding this comment.
Well, I don't really want to downgrade to 1.2.8.
There must be a way to make things work with 1.3.3 as well...
|
Ok, thank you for investigating, even though downgrading to 1.2.8 is not the way forward, I'm afraid. I'll look into things as well... |
|
Ok, the difference between SBT 1.2.8 and 1.3.3 comes from the former relying on Ivy, while the latter uses courier for resolution. These both appear to deal differently with certain conflicts, namely the one that our In the presence of this conflict Ivy decides to put Clearly that is not good thing in either case. The proper solution would be to have So, one way would be to fork |
|
Thanks for that write up, it explains it well. I opened that PR so the problem is narrowed down and you have some quick fix available :) On the long run forking |
|
Please add to build.sbt: or try sbt 1.3.4 - with issue 4688 solved |
|
Fixed by 3ee9ead. |
Seems like sbt 1.3.3 changed resolution mechanism and by bumping up sbt we downgraded sshj
Downgrading sbt to 1.2.8 fixes that issue