-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Println variants have inconsistent spacing #25
Comments
Good catch @aarondl. This is definitely a bug, I'll look into it. |
This can be changed for sure. I originally did this instead of just calling What do you think about having the same concatenation rules, but still leaving out the newline? |
Of course, the newlines are not what we want in a logging package. You'll notice Go's log package already has this behavior: http://golang.org/src/pkg/log/log.go#L124 So what you've mentioned is perfect :D |
Alright, fixed in #26. Let me know if everything looks good to you :) |
entry: log with spaces between all operands on *ln #25
The Go fmt package has different spacing between arguments for Print and Println. This is described in the documentation.
Logrus does not use the same spacing as the go fmt/log packages inhibiting it's ability to be a drop in replacement. Can this be changed or is forking necessary here?
The text was updated successfully, but these errors were encountered: