Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename of Sirupsen -> sirupsen caused glide to fail #566

Closed
dobegor opened this issue Jul 4, 2017 · 12 comments
Closed

Rename of Sirupsen -> sirupsen caused glide to fail #566

dobegor opened this issue Jul 4, 2017 · 12 comments

Comments

@dobegor
Copy link

dobegor commented Jul 4, 2017

This rename caused glide get and glide update fail because some packages import github.com/Sirupsen/logrus (most packages) and some github.com/sirupsen/logrus.

Could you please revert this?

In future, I suggest you to move logrus in organization account.

@dobegor
Copy link
Author

dobegor commented Jul 4, 2017

I.e. Masterminds/glide#863

@dobegor
Copy link
Author

dobegor commented Jul 6, 2017

While I studied the complete history of this (renaming, reverting, then renaming again), I wonder what the hell on Earth would make a developer to do this. I do understand that employee enforce some standard on naming, but it was a long time ago people suggested moving logrus to an organization account and author dismissed it.

Instead of apologies in the README it would make more sense to think out all available consequences of such decision and compare them with the benefit. It not only hurt those projects which didn't use vendoring: many vendored libraries depend on lowercases import and it caused multiple problems with different package managers, especially on case-insensitive systems (God, it was such a mess).

@sirupsen
Copy link
Owner

sirupsen commented Jul 9, 2017

@dobegor this was a failure of a decision, not enough care was taken. I absolutely agree. The only real answer I can give you is that sufficient thought was not put into it, due to many other personal obligations. Clearly, if all this information has been in front of me, I would not have pushed forward.

To improve this going forward, I am looking for maintainers for this project and have already engaged with some who are interested in maintaining it. They will be able to make better decisions than I on this project. I do not work with Go often enough anymore, which is at the end of the day is the root of this failure.

Please see #570 (comment) for the most elaborate comment on this matter.

@dmathieu
Copy link
Contributor

You can fix glide as explained here: #553 (comment)
Closing this issue.

@dobegor
Copy link
Author

dobegor commented Jul 11, 2017

@dmathieu I mentioned that fix won't help if you are running glide on case-insensitive filesystems.
Reopen this issue, please.

@dmathieu
Copy link
Contributor

You can fix this on case-insensitive filesystems fairly easily.

  • Entirely delete the vendorized Sirupsen/logrus package.
  • Check that into GIT (no need to commit. You just need to git add).
  • Rename all occurences of the package name.
  • Fetch the package again, with the name lowercased.
  • Check everything back into GIT.

The rename back into Sirupsen is not something that will happen. Removing the dependency from the project and adding it back lower-cased is the only way you can get it working again.

@dobegor
Copy link
Author

dobegor commented Jul 11, 2017

The problem is there are many third-party dependencies that weren't updated that depend on Sirupsen/logrus and didn't vendor it. "Dependency hell is NP hard" (c) rsc.

@nickhudkins
Copy link

nickhudkins commented Jul 11, 2017 via email

@dobegor
Copy link
Author

dobegor commented Jul 11, 2017

@nickhudkins
Case sensitivity is part of a filesystem, not a UNIX standard/convention etc.

Also, one of the most popular dev OS - macOS - is case insensitive by default.

@nickhudkins
Copy link

nickhudkins commented Jul 11, 2017 via email

@nickhudkins
Copy link

nickhudkins commented Jul 11, 2017 via email

@sjansen
Copy link

sjansen commented Jul 19, 2017

For the benefit of anyone brought here by Google...

solution: #553 (comment)
reason: #570 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants