entry: break out time, level and message from data #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aybabtme oops. Working on some tests. |
This was referenced Jul 27, 2014
| @@ -8,9 +8,24 @@ import ( | |||
| "time" | |||
| ) | |||
|
|
|||
| // An entry is the final or intermediate Logrus logging entry. It containts all | |||
There was a problem hiding this comment.
The comment should start withEntry ...
Golint
As discussed, golint in another PR.
|
Since the fix is implemented in the formatters, what will happen if a user takes a third party formatter? |
|
I think this is a formatter concern, not a concern of Logrus core. You should be able to override this functionality in your own formatters. |
| Level Level | ||
|
|
||
| // Message passed to Debug, Info, Warn, Error, Fatal or Panic | ||
| Message string | ||
| } |
There was a problem hiding this comment.
Putting them as fields of Entry is 👍
sirupsen
added a commit
that referenced
this pull request
Jul 27, 2014
entry: break out time, level and message from data
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #33 and fixes #44.
Please review @aybatme