Fix SetLevel data-race #512
Merged
+51
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om uint8 to uint32 but due memory alignment on most platforms it will not result in any additional memory.
|
Why is there a race here if there's a lock in |
|
Exactly - if we try to set a different level and concurrent goroutine will try to write a log - we will get datarace. |
|
Thanks for the fix! |
This was referenced May 15, 2017
Closed
cgxxv
pushed a commit
to cgxxv/logrus
that referenced
this pull request
Mar 25, 2022
Fix SetLevel data-race
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #374.
The commit fixes data race using atomics Load\Save. We switch type of level from uint8 to uint32 but due memory alignment on most platforms it will not result in any additional memory. This can actually be a breaking change if you store Level somewhere in your code. The alternative would be creating a new type and using it inside
Loggerstruct. On package boundaries we could convert it from existingLevelsilently.