Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "vacation" from the parsed results by default #436

Closed
azumakuniyuki opened this issue Apr 17, 2021 · 0 comments
Closed

Remove "vacation" from the parsed results by default #436

azumakuniyuki opened this issue Apr 17, 2021 · 0 comments
Labels
improvement
Projects
Sisimai 5

Comments

@azumakuniyuki
Copy link
Member

azumakuniyuki commented Apr 17, 2021 •
edited

  • Sisimai does not return a parsed result when the value of "reason" is `vacation by default
  • New argument 'vacation' => 1 will be implemented at Sisimai->rise method
  • The default value of vacation argument is 0`
  • This feature is available from Sisimai 5
@azumakuniyuki azumakuniyuki added this to To Do in Sisimai 5 via automation Apr 17, 2021
azumakuniyuki added a commit that referenced this issue May 4, 2021
@azumakuniyuki
Beginning with v5.0.0, sisimai does not return the result which "reas…
c0777a5 
…on" is "vacation" by default #436
@azumakuniyuki azumakuniyuki mentioned this issue May 4, 2021
Merged
azumakuniyuki added a commit that referenced this issue May 4, 2021
@azumakuniyuki
Update the release note about #436, #437
dbefdde
Sisimai 5 automation moved this from To Do to Done May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
Sisimai 5
Status: Done
Sisimai 5
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@azumakuniyuki