Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wishlist for v0.8 #32

Open
mattuntergassmair opened this issue Dec 16, 2019 · 7 comments
Open

Wishlist for v0.8 #32

mattuntergassmair opened this issue Dec 16, 2019 · 7 comments

Comments

@mattuntergassmair
Copy link
Collaborator

As I was working with AutoViz over the last few weeks I ran into a few limitations and started working on a new (forked) branch that is more flexible and supports my needs better. As discussed with @MaximeBouton we could do a major overhaul of AutoViz to create version 0.8.
Opening this issue so we can collect some improvement ideas. There is also a new branch v0.8 to which we can merge such changes, which could eventually be merged into master.

Current shortcomings include:

  • Vehicles are either basic or fancy. Customizations in how vehicles are drawn are not straightforward. Rendering depends a lot on convert(Renderable, obj) function which cannot easily be changed.
  • Interfaces for rendering different objects (vehicles, overlays, etc.) are different and cannot be extended.
  • overlays can only be "over" the scene (not under vehicles for example)
  • codebase is difficult to navigate (soooo many render functions, all in different packages)
@mattuntergassmair
Copy link
Collaborator Author

I think we should also try to close issues #6, #8, #9 with v0.8, some of them are already fixed on my fork

@MaximeBouton
Copy link
Member

MaximeBouton commented Dec 18, 2019

Here is a checklist, feel free to edit and add stuff:

@MaximeBouton
Copy link
Member

@mattuntergassmair Do you have any idea for #8?

@MaximeBouton
Copy link
Member

@mattuntergassmair how do you feel about the current state of things?
Should we document and merge #43 ?

Should we remove the tutorial notebook?
The main limitation for now is that it also serves as test, I guess we could copy over all the code to the test suite but maybe we should keep that for a future PR.

@mattuntergassmair
Copy link
Collaborator Author

Sounds good. In terms of notebook would be nice to do the same as we did in ADM, i.e. move the notebook over to the docs and find a better way to run the tests. Agree with you that this could happen later.

@mattuntergassmair
Copy link
Collaborator Author

As for documentation, the state of things is not worse than pre-v0.8, so I don't think we lose anything by merging. Better docs are always better, we should try to break the task down into more concrete todo-items and go from there.

@MaximeBouton
Copy link
Member

PR has been merged, release tagged and registered.

I would still wait before closing this one that we add documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants