Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature extraction functionality #70

Closed
MaximeBouton opened this issue Mar 9, 2020 · 2 comments
Closed

Feature extraction functionality #70

MaximeBouton opened this issue Mar 9, 2020 · 2 comments
Labels
Milestone

Comments

@MaximeBouton
Copy link
Member

The current functionality does not support easy logging of features.
Instead we suggest to use DataFrames.

the package would export a feature extraction function:

extract_features(list_of_features, scenes, ids) 

that would return a namedtuple with IDs as keys and a dataframe as values. The column names are automatically determined from the list_of_features given by the user, as symbols.

A feature consist of a type and an extract_features function describing its behavior on a single scene.

@MaximeBouton
Copy link
Member Author

We might want to add roadway as the list of arguments.

@MaximeBouton
Copy link
Member Author

One drawback of using strings or symbol to represent the list of features is that it might be complicated to pass in feature types like "distance to :bob", which would be straightforward by having a type:

struct DistanceToFeature{I} <: AbstractFeature 
    id::I 
end   

# then you could pass DistanceToFeature(:bob) (the naming is a bit awkward)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant