Add GitPoap & Degenscore Data Provider #1555
Conversation
feat: add gitpoap as data provider
…sismo-hub into data-provider-degenscore
Data provider degenscore
markus0x1
changed the title
|
Hi guys @markuschick @3Vis3 @mme022 , please ping me when you need a review, thanks! :) |
|
Hey @MartinGbz 👋 |
| return Object(holders).keys().length; | ||
| } | ||
|
|
||
| public async getGitPoapEventsIDByAddress(address: string ): Promise<FetchedData> { |
There was a problem hiding this comment.
the function here is not really use full because it fetch all the gitpoap ids for an address and returns an empty FetchData object.
And you can't make a group with gitpoap if, you can only create group with web2 or web3 accounts.
So I don't see the utility of this function
There was a problem hiding this comment.
removed with 39b7462
|
@markuschick hey, so it's seems pretty gooof, I just add a comment. |
|
@markuschick if you could now send me the |
Added Json RPC dcf874c |
group-generators/helpers/data-providers/degenscore/interface-schema.json
Outdated
Show resolved
Hide resolved
group-generators/helpers/data-providers/degenscore/interface-schema.json
Outdated
Show resolved
Hide resolved
|
Resolve each review when you fixed them, and ping me when you have finished, thanks 😊 |
|
I already added a new review ;) @markuschick @mme022 |
| ); | ||
| } | ||
|
|
||
| public async getBeaconOwnersWithScore(args: { _score: number }) { |
There was a problem hiding this comment.
@markuschick here you can only pass this: { _score }: Score
And create a score type like this: export type Score = { _score: number }
There was a problem hiding this comment.
fixed with fixed with 61f7d4c
| return dataProfiles; | ||
| } | ||
|
|
||
| public async getGitPoapHoldersByEventIdCount(getGitPoapHoldersArg: {gitPoapEventId: string} ): Promise<number> { |
There was a problem hiding this comment.
fixed with 61f7d4c
|
|
||
| generate: async (context: GenerationContext): Promise<GroupWithData[]> => { | ||
| const degenscoreProvider = new dataProviders.DegenScoreProvider(); | ||
| const addresses = await degenscoreProvider.getBeaconOwnersWithScore(900); |
There was a problem hiding this comment.
You need to change this part of your group, getBeaconOwnersWithScore require a type Score
There was a problem hiding this comment.
fixed with b3ba22f
|
@markuschick @mme022 I added a last review regarding the group |
* Add GitPoap & Degenscore Data Provider (#1555) Co-authored-by: mme <9083787+mme022@users.noreply.github.com> Co-authored-by: 3Vis <francescotrevisan3@gmail.com> Co-authored-by: 3Vis <31535611+3Vis3@users.noreply.github.com> * import groups to index * fix: gitpoap + degenscore providers * fix: degenscore provider --------- Co-authored-by: markus <33206087+MarkuSchick@users.noreply.github.com> Co-authored-by: mme <9083787+mme022@users.noreply.github.com> Co-authored-by: 3Vis <francescotrevisan3@gmail.com> Co-authored-by: 3Vis <31535611+3Vis3@users.noreply.github.com>
fixes
#1430
#1432