feat: data provider for Otterspace #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmme
changed the title
|
Wow a second Data Provider in less than 24h, great job sir! 🔥 |
MartinGbz
reviewed
Mar 22, 2023
group-generators/helpers/data-providers/otterspace/interface-schema.json
Outdated
Show resolved
Hide resolved
|
@MartinGbz , thanks for the feedback, made the suggested changes. 👍 |
MartinGbz
reviewed
Mar 22, 2023
group-generators/helpers/data-providers/otterspace/base-provider.ts
Outdated
Show resolved
Hide resolved
|
@MartinGbz, I think I have it now. Please review again, when time available, thank you. :) |
|
I think it's all good, I merge your PR 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I've added another data provider, this time for Otterspace as proposed in #1438 . I've created a sample group to get a positive test result.