add option to save mus in compute_id_2nn

[diegodoimo]

I believe that we should give access to the mus. This would allow the user to asses the goodness of the model

[codecov-commenter]

Codecov Report

Merging #62 (e246000) into main (a1f83b7) will decrease coverage by 0.05%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
- Coverage   80.61%   80.56%   -0.06%     
==========================================
  Files          10       10              
  Lines        1130     1132       +2     
==========================================
+ Hits          911      912       +1     
- Misses        219      220       +1     

Impacted Files	Coverage Δ
dadapy/id_estimation.py	82.79% <50.00%> (-0.31%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1f83b7...e246000. Read the comment docs.

[AldoGl]

Ok I see your point and I am in favour of this addition, however:

• I don't necessarily agree on having an additional flag. Can't we just save them by default when the set_attr flag is true?

• Also, can we think of a more informative name than "mus"? The name r2_over_r1_ratio could be an option, but I am very open to other ideas or to keep "mus" if you think is better.

@imacocco what's your opinion on this?

[imacocco]

I would definitely avoid another flag. Let's stick to set_attr and make the variable available to the user, maybe with the name r2_r1_ratio.

[diegodoimo]

Don't know about the name. We use mus everywhere in code and in papers and has the advantage to be short to type

[diegodoimo]

good for me

[AldoGl]

Wait, I found a couple of problems, I am fixing them now