Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build improvements #649

Merged
merged 7 commits into from Mar 16, 2024
Merged

build improvements #649

merged 7 commits into from Mar 16, 2024

Conversation

hugo-vrijswijk
Copy link
Contributor

@hugo-vrijswijk hugo-vrijswijk commented Mar 16, 2024 •
edited

  • Updates CI to run on Node 20 and updates Svelte to 4 (though there are no real differences)
  • Use npm ci instead of install for CI and use npm cache for faster installs
  • Update rollup versions
  • Fix svelte accessibility warnings
  • Use .mjs for rollup config (required since latest version of rollup)
  • Remove unused/deprecated rollup plugins
  • Update license field to correct license in package.json

@hugo-vrijswijk hugo-vrijswijk marked this pull request as draft March 16, 2024 13:54
@hugo-vrijswijk
Copy link
Contributor Author

Base is #630, should be merged first

@hugo-vrijswijk hugo-vrijswijk mentioned this pull request Mar 16, 2024
Merged
@hugo-vrijswijk hugo-vrijswijk marked this pull request as ready for review March 16, 2024 14:22
sissbruecker
sissbruecker reviewed Mar 16, 2024
View reviewed changes
Copy link
Owner

@sissbruecker sissbruecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing these chores. The changes in the Svelte components are not as simple unfortunately. I would be fine with leaving them out for now.

bookmarks/frontend/components/SearchAutoComplete.svelte Outdated Show resolved Hide resolved
@sissbruecker sissbruecker merged commit 4bee104 into sissbruecker:master Mar 16, 2024
2 checks passed
@hugo-vrijswijk hugo-vrijswijk deleted the build-improvements branch March 16, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sissbruecker sissbruecker sissbruecker left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hugo-vrijswijk @sissbruecker