Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade @mauron/cordova-plugin/background-geolocation #58

Merged
merged 2 commits into from
Apr 7, 2021

Conversation

noerw
Copy link
Member

@noerw noerw commented Apr 7, 2021

Builds failed with npm 7, because the background geolocation dependency used submodules (ref npm/cli#2774)
I merged the git submodules in our fork of that dependency into a single repo, and this is the update to that newer version, as I'm not sure if/when we can expect a fix in npm..

also (presumably) fixes #16

@noerw noerw added the bug Something isn't working label Apr 7, 2021
@schrooom
Copy link
Collaborator

schrooom commented Apr 7, 2021

Is specifying the exact version within the package.json actually necessary? Shouldn't it be sufficient to just run npm install (maybe while cleaning the node_modules folder once)?

Nevermind, npm doesn't seem to check, if there is a updated version in a git-import.

@schrooom schrooom merged commit 3e4eab0 into develop Apr 7, 2021
@schrooom schrooom deleted the fix-build-problems branch April 7, 2021 13:14
@noerw noerw added build and removed bug Something isn't working labels Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yarn is not working in this project
2 participants