-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Variant Presets #12
Comments
@kdambekalns i would go with the name Primarily the ImageSourceHelperInterface has to be extended for that (not really sure wether to use a combined identifier or two strings here):
While the function has to be implemented in all ImageSourceHelpers it can only have an effect in the scalable ones (Asset and Dummy). In the assetImageSource the asset variant will obviously be switched. In addition the target dimensions have to be adjusted for Asset- and DummyImageSources from the variant configuration which is the part i consider most complicated. The idea is that it should be possible to decide on the actually used variant on the presentation side which will be especially helpful for picture-tags. On top of this it obviously makes sense add a |
@kdambekalns this is released as kaleidoscope 5.1.0. I even managed to make this 4.3 and 5.0 compatible by checking |
I'd have a go at adding support for "variant presets" to Kaleidoscope. But…
First question would be: What to do about the name clash with the existing (thumbnail)
preset
option onImageSource
?Should there be a new option
variant
? And should that be given as<PresetIdentifier>::<VariantIdentifier>
or rather as two new optionsvariantPreset
andvariant
?We could also "reuse" the
preset
option and take it as variant preset when given with::
in the identifier… too magic?Any opinions here, @mficzel, @robertlemke, @kitsunet?
The text was updated successfully, but these errors were encountered: