Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: Prototype Whitelist #114

Merged
merged 1 commit into from Jan 14, 2020
Merged

FEATURE: Prototype Whitelist #114

merged 1 commit into from Jan 14, 2020

Conversation

bwaidelich
Copy link
Contributor

Adds a new configuration option alwaysShowPrototypes that allows
for including prototypes selectively even though they match a
configured hiddenPrototypeNamePatterns:

Sitegeist:
  Monocle:
    hiddenPrototypeNamePatterns:
      - 'Vendor.Components:*'
    alwaysShowPrototypes:
      - 'Vendor.Components:Components.Atom.SomeAtom'
      - 'Vendor.Components:Components.Molecule.SomeMolecule'

Resolves: #89

@bwaidelich
FEATURE: Prototype Whitelist
5bb770c 
Adds a new configuration option `alwaysShowPrototypes` that allows
for including prototypes selectively even though they match a
configured `hiddenPrototypeNamePatterns`:

```yaml
Sitegeist:
  Monocle:
    hiddenPrototypeNamePatterns:
      - 'Vendor.Components:*'
    alwaysShowPrototypes:
      - 'Vendor.Components:Components.Atom.SomeAtom'
      - 'Vendor.Components:Components.Molecule.SomeMolecule'
```

Resolves: sitegeist#89
mficzel
mficzel approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@mficzel mficzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by reading

@bwaidelich
Copy link
Contributor Author

@grebaldi @mficzel Would be great if one of you would push the "merge" button and tag a v6.1.2 <3

@mficzel mficzel merged commit 748a774 into sitegeist:6.0 Jan 14, 2020
@mficzel
Copy link
Member

mficzel commented Jan 14, 2020

Released as v6.2.0 and v7.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mficzel mficzel mficzel approved these changes

@suffle suffle suffle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bwaidelich @mficzel @suffle