Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Prototype Whitelist #114

Merged
merged 1 commit into from Jan 14, 2020

Conversation

@bwaidelich
Copy link
Contributor

bwaidelich commented Jan 13, 2020

Adds a new configuration option alwaysShowPrototypes that allows
for including prototypes selectively even though they match a
configured hiddenPrototypeNamePatterns:

Sitegeist:
  Monocle:
    hiddenPrototypeNamePatterns:
      - 'Vendor.Components:*'
    alwaysShowPrototypes:
      - 'Vendor.Components:Components.Atom.SomeAtom'
      - 'Vendor.Components:Components.Molecule.SomeMolecule'

Resolves: #89

Adds a new configuration option `alwaysShowPrototypes` that allows
for including prototypes selectively even though they match a
configured `hiddenPrototypeNamePatterns`:

```yaml
Sitegeist:
  Monocle:
    hiddenPrototypeNamePatterns:
      - 'Vendor.Components:*'
    alwaysShowPrototypes:
      - 'Vendor.Components:Components.Atom.SomeAtom'
      - 'Vendor.Components:Components.Molecule.SomeMolecule'
```

Resolves: #89
Copy link
Member

mficzel left a comment

Fine by reading

@suffle
suffle approved these changes Jan 14, 2020
@bwaidelich

This comment has been minimized.

Copy link
Contributor Author

bwaidelich commented Jan 14, 2020

@grebaldi @mficzel Would be great if one of you would push the "merge" button and tag a v6.1.2 <3

@mficzel mficzel merged commit 748a774 into sitegeist:6.0 Jan 14, 2020
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mficzel

This comment has been minimized.

Copy link
Member

mficzel commented Jan 14, 2020

Released as v6.2.0 and v7.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.