Respect class inheritance during component argument conversion #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s2b
force-pushed
the
feature/conversionInterface
branch
4 times, most recently
from
2859b61
to
aecf146
Compare
s2b
changed the title
s2b
force-pushed
the
feature/conversionInterface
branch
from
aecf146
to
d1a2a84
Compare
s2b
commented
Mar 27, 2023
Atomschinken
approved these changes
Mar 27, 2023
s2b
force-pushed
the
feature/conversionInterface
branch
from
4f15855
to
85a969a
Compare
s2b
force-pushed
the
feature/conversionInterface
branch
from
09751fd
to
1825217
Compare
s2b
force-pushed
the
feature/conversionInterface
branch
from
1825217
to
b33cac3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, you have to define argument conversion behavior per input class name. That means that if you defined a conversion interface that takes a
FileInterfaceas input, you need to attach this interface toFile,FileReference,ProcessedFilein order to cover all variants.This patch inspects the class structure of the input object and chooses the appropriate conversion automatically.