Changed how files are loaded in DefaultFactory #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
special characters like ## (which are used in tomcat parallel deployment paths) don't cause issues
special characters like ## (which are used in tomcat parallel deployment paths) don't cause issues. If you are using tomcat parallel deployment with the previous version of the code you aren't able to load the sitemesh.xml file.
|
I need this functionality as well. I guess I'll do it on my own if I must but it would be nice to get this merged in. |
|
We also need this fixed in order to take advantage of Tomcat's parallel deployment functionality. Could it be merged? |
|
Since there are two pull requests that fix this already in the queue, and there has been no activity since 2013, I'm guessing it won't be done here. However you can download my copy (eschulma) or the two folks who submitted here, and do an ant build with one command. That's what I did and sitemesh is running in production now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default factory was calling java.util.File.toURL and when that is used it doesn't properly handle some special characters in the file path such as ##. ## is now included in war file names to support Tomcat's Parallel Deployment feature. I identified the issue while working on a project and just wanted to inform you of the issue. There are two commits, involved in this, but really only one change. I didn't like the first commit because I had custom java formatting enabled in my workspace and that caused the code to look like I changed a lot where in reality this is a very simple change.