Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live editor focusing wrong elements #26

Closed
slifin opened this issue Feb 3, 2015 · 6 comments
Closed

Live editor focusing wrong elements #26

slifin opened this issue Feb 3, 2015 · 6 comments

Comments

@slifin
Copy link

slifin commented Feb 3, 2015

It seems to be focusing the element after the one currently hovered over, I'd be interested to know if this issue can be replicated on other people's installs or whether it's something about my page causing the problem

hover problem

@gregpriday
Copy link
Member

I've come across this issue in a few instances and have slowly fixed them. I'll try recreate your setup and see if I can fix it. My first guess is that the empty row is causing a problem, but I'd need to double check this.

@slifin
Copy link
Author

slifin commented Feb 3, 2015

Thank you I appreciate it, would it help if I gave you a wordpress user to login and test with?

@gregpriday
Copy link
Member

It would be very useful. Could you send it to greg@siteorigin.com

@slifin
Copy link
Author

slifin commented Feb 4, 2015

Did you get in okay?

@gregpriday
Copy link
Member

So from the looks of things, the Grid widget you've added to this page isn't properly outputting the before_widget and after_widget arguments. Not having this content is throwing off the live editor because it's not identifying the Grid widget as a widget.

Most widgets do echo out these arguments as recommended by the WordPress docs - http://codex.wordpress.org/Widgets_API

Do you know where you got this widget from so I can report this to them?

@slifin
Copy link
Author

slifin commented Feb 6, 2015

haha embarrassing, I am the author
thank you for taking a look I'll fix this and double check my other widgets for this asap

@slifin slifin closed this as completed Feb 6, 2015
@slifin slifin reopened this Feb 6, 2015
@slifin slifin closed this as completed Feb 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants