-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YoastSEO.js: Add further Yoast compatibility for remaining WB widgets #675
Comments
Adding custom rendering logic to each widget does get really messy. We have 2 options here. The first would be to make server requests for the HTML for each unsupported widget as a fallback. This could be really slow though. The other option would be to dump out all the field values to give Yoast a better chance at picking up text within the widget form. |
I had something like this going in the block editor when trying to solve #647 but with a request for the whole layout's HTML. We already fetch a layout's HTML in the classic editor when Copy Content is enabled, so don't think it'd take too much effort to use that here. |
I had a look at this. So the main issue is that the layout's HTML in the classic editor is encoded in a way that makes it possible to decode back into a full So we have a few possible solutions:
Any suggestions on which solution would be best? |
The last solution seems like the best option as it might solve, at least partially, #647 too. In the end it depends on how much time you want to spend on this. If the answer is "not much" then option 3 seems like a good alternative, albeit with a tradeoff. |
I added a This makes all widget compatible in the classic editor. @braamgenis, could you use this to get content passed to Yoast in the block editor for #647? |
Thanks, G. I'm using the Corp default home page as a demo right now. You can use that same layout by activating Corp and then checking Prebuilt Layouts. The first image below is from the develop branch: The second image is from our new feature compatibility branch: Nine words changes to 203, awesome. But for some reason, the compatibility branch doesn't pick up the outbound link which the develop branch does. The outbound link can be found within the first Hero widget's button. The link is https://wordpress.org/themes/siteorigin-corp/. Any ideas? |
Outbound and inbound links are being detected within the Editor widget. However, they don't appear to be detected within the following widgets: Hero (have added links to the frame content field and the button field) They also aren't detected from the Post Carousel widget but I'd imagine that's expected. |
The outbound and inbound link issues appear to be consistent. In the Accordion widget, the key phrase is detected in the content field but outbound and inbound links aren't detected in that same field. |
@gregpriday I managed to use the action you added to get Yoast's analysis working in the block editor by using the block's |
Epic! That's great news. |
Can anyone confirm that this issue only affects the block editor and not the classic editor for the widgets outlined in the OP? Thanks |
Hi, the Block Editor issue is separately logged #647. In the initial posting of this issue, Alex lists the widgets that are sending to data to Yoast at the moment and those that aren't. That applies to both the Classic Editor. Hope this helps. |
Thanks. So, currently neither editor is working fully with Yoast. Having had a read through the thread, I think option 3 proposed by Greg would be the best option for most scenarios - Give the user the option to change the behaviour of the so_panels_builder_content action so that it returns full HTML. This is the easiest solution and lets the user decide on the tradeoff. Do they want better Yoast compatibility, or do they want to be able to go to and from the classic editor. This is a quick 30 minute solution. |
Sure. At different levels. The Classic Editor has a limitation in terms of the widgets that send data to Yoast. The Block Editor has a bug. Thanks for your feedback. I'm sorry we haven't had the resources to complete this yet. It's definitely very high on our to-do list and will be completed as soon as we're able to. |
No problem at all, I'm just trying to understand where things stand. I'm really not meaning to hassle you guys. :-) |
No worries, not hassling at all, we'd really like to see this resolved, the problem has just been quite challenging. Thanks for checking in. Feel free to reach out at any time, either here, on the forums at https://siteorigin.com/thread/ or via email on support@siteorigin.com if you're using SiteOrigin Premium. Cheers for now :) |
Currently SiteOrigin and Yoast are incompatible due to the "0 words" count. Can I fix this by switching off Guternberg and using classic editor instead? |
According to the list at the top of this threat, the SiteOrigin Button widget should be seen by YOAST. This is partially true. Currently the SiteOrigin Button is also not recognized if using the "select content" option, which shows Post: #post number#. Only Direct URL's are recognized as internal/external links by YOAST. |
Thanks for letting us know. |
The following widgets are currently not added to the Yoast Compatability code:
For reference, the following widgets are currently accounted for:
The text was updated successfully, but these errors were encountered: