Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing in single posts #3

Closed
adiraoco opened this issue Jan 23, 2016 · 4 comments
Closed

Sharing in single posts #3

adiraoco opened this issue Jan 23, 2016 · 4 comments

Comments

@adiraoco
Copy link
Contributor

To add sharing buttons for single posts, I can see 2 ways we can go about it.

  1. we add our own sharing buttons.
  2. we can use Jetpacks Sharing module.

I vote for Jetpack. Gives the users more control over services and the UI. (and less coding for us.. hehehe)

@gregpriday
Copy link
Member

As far as I remember, themes aren't allowed having sharing buttons (by the
wp.org theme review requirements). So Jetpack support is the solution here.
On Sat, 23 Jan 2016 at 7:27 AM Adi Rao notifications@github.com wrote:

To add sharing buttons for single posts, I can see 2 ways we can go about
it.

we add our own sharing buttons.
2.

we can use Jetpacks Sharing module.

I vote for Jetpack. Gives the users more control over services and the UI.
(and less coding for us.. hehehe)


Reply to this email directly or view it on GitHub
#3.

@Misplon
Copy link
Member

Misplon commented May 13, 2016

Sharing is considered plugin functionality so unfortunately, we can't include our own. The Jetpack Sharing module is really nice, let's support that.

@adiraoco
Copy link
Contributor Author

Cool. Will do it.

@Misplon
Copy link
Member

Misplon commented Sep 30, 2016

Done.

@Misplon Misplon closed this as completed Sep 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants