Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headline: esc_html_e($tag) in template causes TranslatePress to break layout #1965

Closed
sitoexpress opened this issue Apr 24, 2024 · 1 comment · Fixed by #1968
Closed

Headline: esc_html_e($tag) in template causes TranslatePress to break layout #1965

sitoexpress opened this issue Apr 24, 2024 · 1 comment · Fixed by #1968

Comments

@sitoexpress
Copy link

sitoexpress commented Apr 24, 2024

While setting up a multilingual website moving form WPML to TranslatePress, everything was almost working fine, but the Headline widget messing up the page HTML in TranslatePress translations.

After some digging, I've noticed that esc_html_e($tag) in tpl/default.php of the Headline widget could be switched with echo esc_attr($tag), since there's no need to escape any actual special html character such as <, keeping things safe while making TranslatePress work fine with headline text translation.

@AlexGStapleton
Copy link
Member

Hi @sitoexpress,

Thank you for reporting this. I've corrected this issue in #1968 and it'll be included in a future SiteOrigin Widgets Bundle update. Thanks again! :)

Kind regards,
Alex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants