temp fix for wrong visual metrics in the HAR #754 (#756)

sitespeedio · Feb 4, 2019 · a6153a6 · a6153a6
1 parent b8a6364
commit a6153a6
Showing 1 changed file with 33 additions and 8 deletions.
diff --git a/lib/core/engine/index.js b/lib/core/engine/index.js
@@ -32,24 +32,49 @@ function shouldDelay(index, total, delay) {
 function addExtraFieldsToHar(totalResults, har, options) {
   if (har) {
     let harPageNumber = 0;
-    for (let harPage of har.log.pages) {
-      let pageNumber = harPageNumber % totalResults.length;
-      for (let iteration = 0; iteration < options.iterations; iteration++) {
-        const visualMetric = totalResults[pageNumber].visualMetrics[iteration];
+    // We test one page
+    // Let's do a better fix for this later on
+    // right now this fixes https://github.com/sitespeedio/browsertime/issues/754
+    if (har.log.pages.length === options.iterations) {
+      for (let harPage of har.log.pages) {
+        let pageNumber = harPageNumber % totalResults.length;
+        const visualMetric =
+          totalResults[pageNumber].visualMetrics[harPageNumber];
         const browserScript =
-          totalResults[pageNumber].browserScripts[iteration];
-        const cpu = totalResults[pageNumber].cpu[iteration];
+          totalResults[pageNumber].browserScripts[harPageNumber];
+        const cpu = totalResults[pageNumber].cpu[harPageNumber];
         harUtil.addExtrasToHAR(
-          iteration,
+          harPageNumber,
           harPage,
           visualMetric,
           browserScript.timings,
           cpu,
           totalResults[pageNumber].info.url,
           options
         );
+        harPageNumber++;
+      }
+    } else {
+      for (let harPage of har.log.pages) {
+        let pageNumber = harPageNumber % totalResults.length;
+        for (let iteration = 0; iteration < options.iterations; iteration++) {
+          const visualMetric =
+            totalResults[pageNumber].visualMetrics[iteration];
+          const browserScript =
+            totalResults[pageNumber].browserScripts[iteration];
+          const cpu = totalResults[pageNumber].cpu[iteration];
+          harUtil.addExtrasToHAR(
+            harPageNumber,
+            harPage,
+            visualMetric,
+            browserScript.timings,
+            cpu,
+            totalResults[pageNumber].info.url,
+            options
+          );
+        }
+        harPageNumber++;
       }
-      harPageNumber++;
     }
   }
 }