Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting a gecko profile on Android do not work #1711

Closed
2 tasks done
soulgalore opened this issue Feb 4, 2022 · 3 comments
Closed
2 tasks done

Getting a gecko profile on Android do not work #1711

soulgalore opened this issue Feb 4, 2022 · 3 comments
Labels

Comments

@soulgalore
Copy link
Member

soulgalore commented Feb 4, 2022

Have you read the documentation?

URL

https://en.m.wikipedia.org/wiki/Barack_Obama

What are you trying to accomplish

Getting a geckorprofiler without setting the android package name through the CLI fails:

sitespeed.io --android -b firefox https://en.m.wikipedia.org/wiki/Barack_Obama --video --visualMetrics -n 1 --browsertime.firefox.geckoProfiler true
[2022-02-04 22:51:31] INFO: Versions OS: darwin 21.3.0 nodejs: v16.13.0 sitespeed.io: 21.6.1 browsertime: 14.18.1 coach: 7.0.0
[2022-02-04 22:51:31] INFO: Run tests on Moto G (5) [ZY322GXR4B] using Android version 7.0
[2022-02-04 22:51:31] INFO: Running tests using Firefox - 1 iteration(s)
[2022-02-04 22:51:31] INFO: Skip install HAR trigger on Android
[2022-02-04 22:51:44] INFO: Testing url https://en.m.wikipedia.org/wiki/Barack_Obama iteration 1
[2022-02-04 22:51:46] INFO: Start GeckoProfiler with features: ["js","stackwalk","leaf"] and threads: ["GeckoMain","Compositor","Renderer"]
[2022-02-04 22:52:01] ERROR: TypeError: Cannot read properties of undefined (reading 'package')
    at GeckoProfiler.stop (/Users/peter/.npm-packages/lib/node_modules/sitespeed.io/node_modules/browsertime/lib/firefox/geckoProfiler.js:106:82)

What browser did you use?

Firefox Android

How to reproduce

sitespeed.io --android -b firefox https://en.m.wikipedia.org/wiki/Barack_Obama --video --visualMetrics -n 1 --browsertime.firefox.geckoProfiler true

Relevant log output

No response

@soulgalore soulgalore added the bug label Feb 4, 2022
@soulgalore
Copy link
Member Author

Storing the geckoprofiler needs: this.firefoxConfig.android.package but I guess then that it isn't set.

@soulgalore
Copy link
Member Author

Setting --browsertime.firefox.android.package org.mozilla.firefox fixes the problem.

soulgalore added a commit that referenced this issue Feb 5, 2022
soulgalore added a commit that referenced this issue Feb 5, 2022
@soulgalore
Copy link
Member Author

Fixed and released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant