Get the url from the result array in GeckoProfiler.stop
#1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously for gecko profiler commands we were getting the test url by running a script that returns `document.documentURI`. This was working fine for most cases. But when one of our tests actually navigates to a different page from the starting page, it gets the destination url instead of the initial url. Since we need the initial url, it's better not to get the url like this, and get it directly from the `result` array. Note that chrome trace command does something similar [here](https://github.com/sitespeedio/browsertime/blob/e3e5a46f6c9070c0ab66e543b85e60d021edc848/lib/core/engine/command/chromeTrace.js#L42).
|
Cool, let me rerun the tests to see the unit tests come through. There are two other actions that will fail at the moment: Chromedriver/Chrome has some breaking changes in the upcoming 119 release (the current driver doesn't work with upcoming releases) so lets merge with those failing. |
|
@soulgalore thanks! It looks like the unit tests are failing again but they are passing locally. |
|
Yeah, the tests always work on my machine too ;) Something is flakey in that action I will have a look at it later on. Thanks for the PR @canova |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously for gecko profiler commands we were getting the test url by running a script that returns
document.documentURI. This was working fine for most cases. But when one of our tests actually navigates to a different page from the starting page, it gets the destination url instead of the initial url. Since we need the initial url, it's better not to get the url like this, and get it directly from theresultarray.Note that chrome trace command does something similar here.
cc @soulgalore and @92kns
This fixes Bug 1858709