Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

Merged DOM/HAR result is not working correctly #42

Closed
soulgalore opened this issue Mar 15, 2016 · 2 comments
Closed

Merged DOM/HAR result is not working correctly #42

soulgalore opened this issue Mar 15, 2016 · 2 comments
Labels
bug

Comments

@soulgalore
Copy link
Member

When we implemented the coachAdvice structure in the DOM result, the merge broke.

  1. Create tests that checks output from the CLI
  2. Fix the merge issues.
@soulgalore soulgalore added the bug label Mar 15, 2016
soulgalore added a commit that referenced this issue Mar 15, 2016
@soulgalore
Use same structure for HAR and DOM advice results
050e84b 
When we changed the DOM structure to work with Browsertime we broke
the merging of DOM & HAR. We din't had good tests up and running
so we missed it.

HAR now follows the same structure as DOM and we have a simple test
that can be better in the future. #42
@soulgalore
Copy link
Member Author

We could add some love to the cli test case so we are even more sure the next time something like this happens.

@soulgalore
Copy link
Member Author

added tests to take care of it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@soulgalore