Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease the size of the default container #2911

Closed
soulgalore opened this issue Mar 7, 2020 · 2 comments
Closed

Decrease the size of the default container #2911

soulgalore opened this issue Mar 7, 2020 · 2 comments

Comments

@soulgalore
Copy link
Member

The size of the container hasn't got any love for a while and the size has grown over time. Lets see how we can make it smaller + maybe build a couple of special containers as small as possible.

@soulgalore
Copy link
Member Author

This actually a bigger thing than I thought. The problem is "hidden" feature of using npm-shrinkwrap. Most of our projects use that. That works fine so we know exact which version to use. Then running npm install --production also works fine for one project, only dependencies is installed (even though the dev dependencies exist in the lock file).

Running on Travis we use that lock file to install, so that lock file needs to also include the dev dependencies (you can create lock files without it by pruning and --production but that kind breaks CI.

For a project that then depends on a project with a npm-shrinkwrap file, and you run npm install --production it actually installs all dependencies including dev-dependencies :O

That means through the chain of the gecko driver download, that is used by browsertime, browsertime is used by the coach, and the coach is used buy sitespeed.io. If all these packages use a shrink-wrap file, all their dev dependencies ends up in npm run install --production for sitespeed.io. I need to file an upstream issue for this so at least I can understand how it should be used. But for now I've been removing shrink-wrap files. Potentially it can make install breaks for people but I don't see a way forward to fix this for now. When I'm finished I'll write down how much data we are actually are talking about.

@soulgalore
Copy link
Member Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant