Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.json plugin add field no work #3744

Closed
2 tasks done
linqunhe opened this issue Oct 19, 2022 · 4 comments
Closed
2 tasks done

config.json plugin add field no work #3744

linqunhe opened this issue Oct 19, 2022 · 4 comments
Labels

Comments

@linqunhe
Copy link

linqunhe commented Oct 19, 2022

Have you read the documentation?

URL

https://glitch.com/

What are you trying to accomplish

use json config:

image

add plugin no work

image

use load field , it work , but output warning
image
image

What browser did you use?

Other

How to reproduce

{
  "browsertime": {
    "iterations": 1,
    "browser": "chrome",
    "viewPort": "1920x1080",
    "cpu": true,
    "spa": true,
    "delay": 1000,
    "cacheClearRaw": true,
    "videoParams": {
      "framerate": 24,
      "filmstripQuality": 50,
      "convert": false,
      "createFilmstrip": false
    },
    "screenshotParams": {
      "png": {
        "compressionLevel": 5
      }
    },
    "timeouts": {
      "pageCompleteCheck": 4500000
    },
    "visualMetricsPortable": true,
    "skipHar": true,
    "chrome": {
      "collectNetLog": true,
      "timeline": true,
      "collectLongTasks": true
    }
  },
  "decimals": 2,
  "utc": true,
  "summaryDetail": true,
  "html": {
    "topListSize": 3,
    "logDownloadLink": false,
    "showScript": false,
    "fetchHARFiles": true
  },
  "filmstrip": {
    "showAll": false
  },
  "plugins": {
    "list": true,
    "add": [
      "analysisstorer",
      "coach"
    ],
    "remove": [
      "axe",
      "sustainable",
      "/lighthouse",
      "/gpsi",
      "budget",
      "assets",
      "grafana",
      "graphite",
      "slack",
      "s3"
    ]
  },
  "useHash": true
}

Relevant log output

No response

@linqunhe linqunhe added the bug label Oct 19, 2022
@soulgalore
Copy link
Member

Hi @linqunhe thanks for creating the issue, let me have a look at it later today.

@soulgalore soulgalore transferred this issue from sitespeedio/browsertime Oct 19, 2022
@soulgalore
Copy link
Member

If I use add it seems to work for me:

config.json

{
    "plugins": {
      "list": true,
      "add": [
        "analysisstorer"
      ],
      "remove": [
        "coach"
      ]
   }
}
sitespeed.io --config config.json https://www.sitespeed.io -n 1 -o
...
[2022-10-19 13:05:29] INFO: The following plugins are enabled: assets, browsertime, budget, domains, harstorer, html, lateststorer, metrics, pagexray, remove, text, thirdparty, tracestorer, analysisstorer
....

@linqunhe
Copy link
Author

Hi, I have retry...
I don’t seem to be able to do it here, and my configuration file uses the inheritance scheme you provided, you can see the video execution effect

Untitled.1.mp4

env

  • node 16
  • macos
  • docker
  • sitespeed 26.1.0

tks...

@soulgalore
Copy link
Member

I couldn't reproduce so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants