This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
Seems to fix a NullPointerException on Android 8.0+ built with API 28 #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this still working on lower Android versions? Did you test that? |
|
I did not test, but as per https://developer.android.com/distribute/best-practices/develop/target-sdk All the app submissions must target API level 28 as a minimum |
regnete
reviewed
Aug 19, 2020
| android:name="de.sitewaerts.cordova.documentviewer.FileProvider" | ||
| android:authorities="$PACKAGE_NAME.DocumentViewerPlugin.fileprovider" | ||
| android:authorities="${applicationId}.DocumentViewerPlugin.fileprovider" |
There was a problem hiding this comment.
Why did you change this from
There was a problem hiding this comment.
@regnete This will be help full if you have multiple variants(dev, staging prod) for your app and you want to install all the builds simultaneously. Then applicationId will help or else it will throw the following error
Failure [INSTALL_FAILED_CONFLICTING_PROVIDER: Scanning Failed.:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone who actually knows what they are doing will need to check this. It seems to fix the issue I had