Added capability to import module files from device / network drive / cloud services #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The identification of modules in 4champ is based on Amiga Music Preservation module ids, which conveniently is a sequence of integers. The solution for bringing in modules from other sources - in the context of this PR, from local file system, I went for splitting the id space in ranges: first million for AMP, second million for local modules, and added a secondary key
serviceKeyfor storing range-specific identifier for the module, and serviceType to identify the service from which the item is from. In the case of modules imported through the file import feature, filename is stored to the serviceKey field.