Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more file extensions #28

Merged
merged 1 commit into from Jan 31, 2024
Merged

Conversation

mothcompute
Copy link
Contributor

libopenmpt supports more formats than 4champ recognizes the file extensions of. This commit should add some of the missing file extensions to Info.plist and alphabetize them.

@sitomani
Copy link
Owner

sitomani commented Dec 20, 2023

Thanks for the PR!

Can you do one more thing; the formats that you've now added to info.plist will only make the iOS-side mapping work for the extensions. In order for the player engine to pick them up, the added extensions need to be also added to MTPReplayer::supportedFormats in 4champ/Replay/OpenMPT/MPTReplayer.m, but don't add MED, AHX, THX HVL which are handled by other replayers.

Copy link
Owner

@sitomani sitomani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment above.

@sitomani
Copy link
Owner

Let's go with this, I'll adjust the MPTReplayer in a separate commit.

@sitomani sitomani merged commit 6c23edd into sitomani:master Jan 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants