Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace outline variables in docstrings #14

Closed
cbandy opened this issue Mar 23, 2015 · 6 comments
Closed

Replace outline variables in docstrings #14

cbandy opened this issue Mar 23, 2015 · 6 comments
Assignees

Comments

@cbandy
Copy link
Contributor

cbandy commented Mar 23, 2015

Feature: Scenario Outline with DocString

Scenario Outline: Something
  Given something is:
    """
    <how> functional
    """

Examples: 
  | how       |
  | minimally |
step.PyString().String() == "minimally functional\n"
@ppeble ppeble self-assigned this Mar 25, 2015
@ppeble
Copy link
Contributor

ppeble commented Mar 25, 2015

I've started work on this.

@ppeble
Copy link
Contributor

ppeble commented Mar 26, 2015

@cbandy Can you help me understand the expected behavior for the following?

Feature: Scenario Outline with DocString

Scenario Outline: Something
  Given something is:
    """
    <how> functional
    """

Examples: 
  | how       |
  | minimally |
  | incredibly |

Based on my understanding this should execute the scenario twice with the two values like:

step.PyString().String() == "minimally functional\n"
step.PyString().String() == "incredibly functional\n"

In addition, if we have multiple values in the examples then I assume that those should be replaced as well:

Feature: Scenario Outline with DocString

Scenario Outline: Something
  Given something is:
    """
    <how> functional <really_though>
    """

Examples: 
  | how         | really_though    |
  | minimally | barely                |
  | incredibly | overwhelmingly |

I assume it should look like:

step.PyString().String() == "minimally functional barely\n"
step.PyString().String() == "incredibly functional overwhelmingly\n"

Correct?

@zombor
Copy link
Contributor

zombor commented Mar 26, 2015

This seems correct to me.

@ppeble
Copy link
Contributor

ppeble commented Mar 26, 2015

Thanks, just wanted another set of eyes before I finished up.

@ppeble
Copy link
Contributor

ppeble commented Mar 26, 2015

PR for this specific issue: #16

@ppeble
Copy link
Contributor

ppeble commented Mar 27, 2015

Previous PR merged to master.

@ppeble ppeble closed this as completed Mar 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants