Upgrade aws sdk v2 #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zacwolfe Hey, this is excellent. I will take a deep look at the PR soon and let you know. |
| @@ -30,6 +30,14 @@ | |||
| <groupId>org.springframework.boot</groupId> | |||
| <artifactId>spring-boot-maven-plugin</artifactId> | |||
| </plugin> | |||
| <plugin> | |||
There was a problem hiding this comment.
In Spring Boot application, configuring <java.version> property is sufficient to set Java version. We can remove the maven-compiler-plugin configuration.
| <testcontainers.version>1.17.6</testcontainers.version> | ||
| <localstack-starter.version>0.0.3-SNAPSHOT</localstack-starter.version> | ||
| <java.version>17</java.version> | ||
| <aws.sdkv2.version>2.20.143</aws.sdkv2.version> |
There was a problem hiding this comment.
I think it is better to keep the name of this property <aws-java-sdk.version> and update the version to the latest so that even if there is a v3 version we don't have to keep changing this property all over the place.
There was a problem hiding this comment.
Yes, thank you! BTW, I've been doing mostly scala for the last several years so my Java/Maven/Spring is rusty, trying to catch up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code upgrades the project to AWS SDK v2. The unit test and sample code has been updated to use the new async APIs. It should be noted that the intention of this work was merely to get things working with the v2 SDK while employing minimal effort. By no means should the updated code in the sample or unit tests be considered exemplary models of how these APIs should be employed in production environments.