-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade aws sdk v2 #16
base: master
Are you sure you want to change the base?
Conversation
@zacwolfe Hey, this is excellent. I will take a deep look at the PR soon and let you know. |
@@ -30,6 +30,14 @@ | |||
<groupId>org.springframework.boot</groupId> | |||
<artifactId>spring-boot-maven-plugin</artifactId> | |||
</plugin> | |||
<plugin> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Spring Boot application, configuring <java.version>
property is sufficient to set Java version. We can remove the maven-compiler-plugin configuration.
<testcontainers.version>1.17.6</testcontainers.version> | ||
<localstack-starter.version>0.0.3-SNAPSHOT</localstack-starter.version> | ||
<java.version>17</java.version> | ||
<aws.sdkv2.version>2.20.143</aws.sdkv2.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is better to keep the name of this property <aws-java-sdk.version>
and update the version to the latest so that even if there is a v3 version we don't have to keep changing this property all over the place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thank you! BTW, I've been doing mostly scala for the last several years so my Java/Maven/Spring is rusty, trying to catch up!
This code upgrades the project to AWS SDK v2. The unit test and sample code has been updated to use the new async APIs. It should be noted that the intention of this work was merely to get things working with the v2 SDK while employing minimal effort. By no means should the updated code in the sample or unit tests be considered exemplary models of how these APIs should be employed in production environments.