Correct average latency calculation in best server determination. #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts part of commit c1b9a0d. I guess some exploratory or debugging edits made it into the commit. Three samples are run, summed, and divided by six. It should be three. As a result, the latency results were halved. The "best" server was still chosen but the ping time displayed was half of the real average result.
|
If the real speedtest widget or app also divides it by six or something, then I guess it doesn't consider "ping" to be the RTT and is dividing further to get (I guess?) the trip time. |
|
This was purposeful. |
|
Thanks for clarifying. I wasn't sure if that was supposed to be a RTT or not. |
nelsonjchen
added a commit
to nelsonjchen/speedtest-rs
that referenced
this pull request
Nov 15, 2015
Repository owner
locked and limited conversation to collaborators
Nov 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts part of commit c1b9a0d. I guess some exploratory or debugging edits
made it into the commit.
Three samples are run, summed, and divided by six. It should be three.
As a result, the latency results were halved. The "best" server was still
chosen but the ping time displayed was half of the real average result.