Fix output of unicode strings with Python 3 #233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is already fixed in another branch that will become the next major release. |
Merged
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Feb 24, 2016
Upstream will not fix this until the next release sivel/speedtest-cli#233 Package-Manager: portage-2.2.27
Repository owner
locked and limited conversation to collaborators
Nov 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current code, Python 3 prints
bytesinstead ofstr, which causes the output to be broken (this is especially problematic for--listbecause the newlines are not interpreted).I tested my fix with Python 2.4, 2.7 and 3.5. It should not break anything for old versions.
This passes pep8 and pyflakes. I don't have a pypy install to test with but I don't see why it would fail as it's fairly trivial.