Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: add --search #732

Closed
wants to merge 3 commits into from
Closed

update: add --search #732

wants to merge 3 commits into from

Conversation

du5
Copy link

@du5 du5 commented May 8, 2020

#726 #717

python speedtest.py --search="United States"
# python speedtest.py --search "United States"
# set server by search result
python speedtest.py --search="United States" --server 18531
# test command
curl -s https://raw.githubusercontent.com/du5/speedtest-cli/7b3309c/speedtest.py \
| python - --search="United States"
pip install git+https://github.com/du5/speedtest-cli.git
speedtest --search="Hong Kong"
speedtest --search="Hong Kong" --server=13538 --share

@du5 du5 force-pushed the master branch 4 times, most recently from c1d19b2 to 4fce6a4 Compare May 8, 2020 15:18
@du5 du5 force-pushed the master branch 2 times, most recently from 9840afb to 216e0b3 Compare May 9, 2020 08:34
@pepa65
Copy link

pepa65 commented Sep 14, 2020

Great addition/improvement, the --search option!

@deliciouslytyped
Copy link

deliciouslytyped commented Sep 23, 2020

@sivel Could you merge / is there a reason this hasn't been merged?

It would also be helpful to be able to manually specify a target. , because --server ID fails if the server isn't returned by the limited list given by the php page. Edit: I see you are supposed to combine --search with --server. Please merge, works great.

This would also provide a workaround in the interim for the people who find the current --server behaviour too limited.

@deliciouslytyped
Copy link

Nitpick: --list still lists the usual list instead of the search results.

@du5
Copy link
Author

du5 commented Sep 25, 2020

@deliciouslytyped haha, Maybe he forgot his GitHub password

@sivel sivel closed this Sep 25, 2020
@huyz
Copy link

huyz commented Sep 28, 2020

Why was this PR closed without comment? Was it @du5's joke that offended @sivel ?

@pepa65
Copy link

pepa65 commented Sep 28, 2020

It would be good to know the reason, for @du5 and potential future contributors.

Repository owner deleted a comment from pkishino Jan 19, 2021
Repository owner locked as resolved and limited conversation to collaborators Jan 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants