Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing grep $domain Command in webprobe_full() Function #859

Closed
borhanDZ opened this issue Mar 16, 2024 · 1 comment
Closed

Missing grep $domain Command in webprobe_full() Function #859

borhanDZ opened this issue Mar 16, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@borhanDZ
Copy link

I would like to point out that what is stated here might not be of utmost importance or is considered a mistake, in my opinion.

Details:

  • Function Assigned : webprobe_full() at line 1432.
  • Issue: The grep $domain code snippet is missing.
  • Observation:
    • In the function webprobe_simple() at line 1395, a similar command semantic is present.
    • However, this command is missing in webprobe_full() at line 1432.
      ... cat .tmp/web_full_info_uncommon.txt | jq -r 'try . |"\(.url) [\(.status_code)] [\(.title)] [\(.webserver)] \(.tech)"' | anew -q webs/web_full_info_uncommon_plain.txt

Suggestion:

It might be beneficial to apply the grep $domain filter to multiple domains, rather than just example.com. For instance, in the target, there could be variations like example.com|net|de|io|co.

Conclusion:

Thank you for creating this wonderful script. This feedback is provided with the intention of improving it further.

@borhanDZ borhanDZ added the bug Something isn't working label Mar 16, 2024
@six2dez
Copy link
Owner

six2dez commented Mar 18, 2024

Thx! Fixed on dev branch, I will push to main soon :)

@six2dez six2dez closed this as completed Mar 18, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants