Bug fixes #439
Merged
Bug fixes #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.1.4 preparing release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line 109 in
install.shfails withpackage not foundbecause ofhexdump.This creates a knock-on effect where several Golang tools (those that require GCC) & all python tools fail to install correctly.
I believe we want
libdata-hexdump-perl, however there is also alibdata-hexdumper-perl. I'm not sure which one is the right one.Line 221 symlinks
/usr/local/bin/pip3to itself - which doesn't make any sense. It might be a typo? I've just commented it for now.I have tested with these two changes & they produce a working installation.
Peek.2021-12-29.21-38.mp4
P.S. Why am I making 4 commits? I don't understand what I'm doing wrong...