feat: support custom output path in notify flow #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotfixes
fix debug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the logic for sending the output zip to subscribers via notify.
Currently, we assume the output path is the same as
$SCRIPTPATH, but this is a bad assumption. Anyone following Data Keep would run into this issue since it implies the creation of a custom/Reconoutput directory. And I believe$dir_output=$SCRIPTPATHin the case of defaults (maybe double check this) so it shouldn't cause any issues for users who are not setting a custom output location.@six2dez WDYT? 馃憖