Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: unused entry for git repository install section #642

Merged
merged 2 commits into from
Feb 4, 2023
Merged

refactor: unused entry for git repository install section #642

merged 2 commits into from
Feb 4, 2023

Conversation

kharaone
Copy link
Contributor

@kharaone kharaone commented Feb 3, 2023

  • byp4xx is installed through go install and not through the git repository.
  • There was an entry in the git repo section that was clearly a forgotten work in progress. It was seemingly copied from the regulator key on the line above.

@kharaone kharaone changed the title refactor: unused entry for repository refactor: unused entry for git repository install section Feb 3, 2023
six2dez
six2dez requested changes Feb 3, 2023
View reviewed changes
Copy link
Owner

@six2dez six2dez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the PR, however the fix is not removing the line but changing to the right repo name = repos["byp4xx"]="lobuhi/byp4xx" because byp4xx requires both the binary and the payloads on the repo. Please change it and accept the review

@kharaone
fix: repository is still needed for non binary assets
3846e46 
- the repository still contains assets used by the binary (ie, payloads)
@kharaone
Copy link
Contributor Author

kharaone commented Feb 4, 2023

Apologies for this oversight.

@kharaone kharaone requested a review from six2dez February 4, 2023 17:08
@six2dez six2dez merged commit 6ba9af9 into six2dez:dev Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@six2dez six2dez Awaiting requested review from six2dez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kharaone @six2dez