Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes rules out of order #77

Merged
merged 3 commits into from
Apr 16, 2015
Merged

Fixes rules out of order #77

merged 3 commits into from
Apr 16, 2015

Conversation

ddomingues
Copy link
Contributor

This pull request adds a property sorter that fixes the issue #72 created by @nykolaslima. I implemented following the solution used by @Tavio.

public class PropertySorter {

private static final String CYCLIC_MESSAGE_ERROR = "Fixture Factory failed to calculate ${} field references. Either a cyclic dependency exists or one of the fields references a non-existent field.";
private final Map<String, Property> mapedProperties;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo here: mapedProperties -> mappedProperties

@nykolaslima
Copy link
Member

Just a little typo, but it looks good to me.
I would like if @Tavio could take a look at it. @ahirata and @aparra it would be nice if you guys could take a look at it too.

@nykolaslima
Copy link
Member

@ddomingues I'm sorry for taking so long to merge it. It was busy days for me.

Thank you for contributing.

nykolaslima added a commit that referenced this pull request Apr 16, 2015
@nykolaslima nykolaslima merged commit d4d1db9 into six2six:master Apr 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants