Update dependencies and switch to GitHub Actions #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathany-copia
commented
Feb 22, 2023
Comment on lines
-5
to
+6
| config :streamex, region: "", | ||
| key: "8andj8c67ycp", | ||
| secret: "6anbcfx3a5awa62ehtmjfnzdn74shg9tcbbwrpfrdmeaf2t5f3pddfsj9ewpjnv7" | ||
| config :streamex, | ||
| region: "", | ||
| key: "bxfd3qv7c56c", | ||
| secret: "8zmdu5aq6v6uk273ht9jzsnqnh8v33dsp9f23pjh3ngegc9pndeg2ntgk594quee" |
There was a problem hiding this comment.
If this is okay for now (no worse than before), I can do a follow-up to remove the secrets from config and VCRs.
nathany-copia
commented
Feb 22, 2023
| @api_url "api.getstream.io/api" | ||
| @default_timeout 3000 | ||
| @api_url "api.stream-io-api.com/api" |
There was a problem hiding this comment.
I'm seeing https://chat.stream-io-api.com in the official Go client, so we probably need to update this and regenerate all the VCRs.
https://github.com/GetStream/stream-chat-go/blob/master/client.go#L29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sixFingers I found your project via the https://github.com/GetStream/streamex fork/mirror. I saw in #12 that you don't have time to devote to this package, but I hope you still find time to do a quick review/merge (or maybe some other people could review instead).
This pull request brings together the changes from @ntilwalli (#11) and the subsequent work of @ronaldcurtis. I also updated the dependencies to latest and swapped out Travis CI for GitHub Actions (please let me know if you have a preference).
Thanks to their efforts, everything is compiling with deprecation warnings resolved and tests passing.
I haven't yet had a chance to thoroughly go through #10 (via @shavit https://github.com/shavit/streamex) or the other forks yet. It may be worth looking at the work in https://github.com/avail-app/streamex too (@JamieREvans).
I hope to do some experimenting with the library which may result in some further updates over the next few days, but it would be nice to get this merged to master as a foundation for that work (and anyone else using the library).