.NET Core Support (nats-io#37)

[ADDED] .NET Core Support

README.md

@@ -17,16 +17,17 @@ NATS Streaming provides the following high-level feature set:
 ## Notes
 - Please raise questions/issues via the [Issue Tracker](https://github.com/nats-io/csharp-nats-streaming/issues) or via natsio.slack.com (contact larry@apcera.com or brian@apcera.com for access)
 
-## Known Issues
-- Time- and sequence-based subscriptions are exact. Requesting a time or seqno before the earliest stored message for a subject will result in an error when creating a subscription.
-
 ## Installation
 
-The NATS streaming .NET client can be installed manually by downloading the source and building.  [NuGet](www.nuget.com) and an environment to build [Visual Studio](https://www.visualstudio.com/en-us/products/visual-studio-community-vs.aspx) project files is required.
+For convenience, the NATS streaming client can found on NuGet as [STAN.Client](https://www.nuget.org/packages/STAN.Client/).  
+
+Alternatively, you can build the C# NATS streaming client yourself.  To build, you'll need an environment to build [Visual Studio](https://www.visualstudio.com/en-us/products/visual-studio-community-vs.aspx) and/or .NET core project files.
 
-From the directory the repository has been cloned into, either invoke `build.bat` from the command line, or open the `STAN.sln` project file in Visual Studio and build from there.
+### .NET core
+From the directory the repository has been cloned into, either invoke `buildcore.bat` from the command line, or open the `STANcore.sln` project file in Visual Studio and build from there.
 
-NuGet packages will be coming soon.
+### .NET 4.5
+From the directory the repository has been cloned into, either invoke `build45.bat` from the command line, or open the `STANnet45.sln` project file in Visual Studio and build from there.
 
 ### API Documentation
 
@@ -154,7 +155,6 @@ var s = c.Subscribe("foo",  opts, (obj, args) =>
 
 NATS Streaming subscriptions **do not** support wildcards.
 
-
 ## Advanced Usage
 
 ### Asynchronous Publishing
@@ -173,7 +173,9 @@ var guid = await c.PublishAsync("foo", null);
 
 // alternatively, one can work in some application code.
 var t = c.PublishAsync("foo", null);
-// application code
+
+// your application can do work here
+
 guid = await t;
 ```
 
@@ -278,7 +280,7 @@ var s = c.Subscribe("foo", sOpts, (obj, args) =>
 ```
 
 ## TODO
-- [ ] Core 1.0 support
+- [X] Core 1.0 support
 - [ ] Rx API
 - [ ] Robust Benchmark Testing
 - [X] CI (Appveyor)

STAN.CLIENT/Options.cs

@@ -22,21 +22,21 @@ public sealed class StanOptions
 
         internal StanOptions() { }
 
-        private string deepCopy(string value)
+        internal static string DeepCopy(string value)
         {
             if (value == null)
                 return null;
 
-            return string.Copy(value);
+            return new string(value.ToCharArray());
         }
 
         internal StanOptions(StanOptions options)
         {
             ackTimeout = options.ackTimeout;
-            NatsURL = deepCopy(options.NatsURL);
+            NatsURL = DeepCopy(options.NatsURL);
             ConnectTimeout = options.ConnectTimeout;
             PubAckWait = options.PubAckWait;
-            DiscoverPrefix = deepCopy(options.DiscoverPrefix);
+            DiscoverPrefix = DeepCopy(options.DiscoverPrefix);
             MaxPubAcksInFlight = options.MaxPubAcksInFlight;
             NatsConn = options.natsConn;
         }

STAN.CLIENT/STAN.CLIENT.xproj

@@ -0,0 +1,19 @@
+<?xml version="1.0" encoding="utf-8"?>
+<Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+  <PropertyGroup>
+    <VisualStudioVersion Condition="'$(VisualStudioVersion)' == ''">14.0</VisualStudioVersion>
+    <VSToolsPath Condition="'$(VSToolsPath)' == ''">$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)</VSToolsPath>
+  </PropertyGroup>
+  <Import Project="$(VSToolsPath)\DotNet\Microsoft.DotNet.Props" Condition="'$(VSToolsPath)' != ''" />
+  <PropertyGroup Label="Globals">
+    <ProjectGuid>23ee6838-d8a6-4787-bafb-2148ef6f5b79</ProjectGuid>
+    <RootNamespace>STAN.CLIENT</RootNamespace>
+    <BaseIntermediateOutputPath Condition="'$(BaseIntermediateOutputPath)'=='' ">.\obj</BaseIntermediateOutputPath>
+    <OutputPath Condition="'$(OutputPath)'=='' ">.\bin\</OutputPath>
+  </PropertyGroup>
+
+  <PropertyGroup>
+    <SchemaVersion>2.0</SchemaVersion>
+  </PropertyGroup>
+  <Import Project="$(VSToolsPath)\DotNet\Microsoft.DotNet.targets" Condition="'$(VSToolsPath)' != ''" />
+</Project>

STAN.CLIENT/StanConnection.cs

@@ -57,8 +57,7 @@ internal PublishAck(Connection conn, string guid, EventHandler<StanAckHandlerArg
 
             ah = handler;
             guidValue = guid;
-            ackTimer = new Timer(ackTimerCb);
-            ackTimer.Change(timeout, Timeout.Infinite);
+            ackTimer = new Timer(ackTimerCb, null, (int)timeout, Timeout.Infinite);
         }
 
         internal string GUID

STAN.CLIENT/SubscriptionOptions.cs

@@ -34,7 +34,7 @@ internal StanSubscriptionOptions(StanSubscriptionOptions opts)
 
             if (opts.durableName != null)
             {
-                this.durableName = string.Copy(opts.durableName);
+                durableName = StanOptions.DeepCopy(opts.durableName);
             }
 
             manualAcks = opts.manualAcks;

STAN.CLIENT/project.json

@@ -0,0 +1,25 @@
+{
+  "description": "STAN Client API",
+  "copyright": "Copyright © Apcera 2017",
+  "title": "STAN Client",
+  "version": "0.1.4-*",
+  "dependencies": {
+    "NETStandard.Library": "1.6.0",
+    "NATS.Client": "0.7.0",
+    "System.Reflection.Extensions": "4.3.0",
+    "System.Runtime": "4.3.0",
+    "System.Runtime.Serialization.Primitives": "4.3.0",
+    "System.Threading.Thread": "4.3.0",
+    "Google.Protobuf": "3.2.0",
+    "Google.Protobuf.Tools": "3.2.0",
+    "System.Runtime.Serialization.Json": "4.3.0"
+  },
+  "frameworks": {
+    "netstandard1.6": {
+      "imports": "dnxcore50"
+    }
+  },
+  "buildOptions": {
+    "xmlDoc": true
+  }
+}

STAN.Client.UnitTests/Nuget.Config

@@ -0,0 +1,9 @@
+<?xml version="1.0" encoding="utf-8"?>
+<configuration>
+  <packageSources>
+    <add key="STAN.Client" value="../STAN.Client/bin/Release" />
+  </packageSources>
+  <config>
+    <add key="repositoryPath" value="../STAN.Client/bin/Release" />
+  </config>
+</configuration>

STAN.Client.UnitTests/STAN.Client.UnitTests.xproj

@@ -0,0 +1,21 @@
+<?xml version="1.0" encoding="utf-8"?>
+<Project ToolsVersion="14.0.25420" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+  <PropertyGroup>
+    <VisualStudioVersion Condition="'$(VisualStudioVersion)' == ''">14.0.25420</VisualStudioVersion>
+    <VSToolsPath Condition="'$(VSToolsPath)' == ''">$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)</VSToolsPath>
+  </PropertyGroup>
+  <Import Project="$(VSToolsPath)\DotNet\Microsoft.DotNet.Props" Condition="'$(VSToolsPath)' != ''" />
+  <PropertyGroup Label="Globals">
+    <ProjectGuid>9a3ea015-7552-417d-a3d9-698d664e954c</ProjectGuid>
+    <RootNamespace>STAN.Client.UnitTests</RootNamespace>
+    <BaseIntermediateOutputPath Condition="'$(BaseIntermediateOutputPath)'=='' ">.\obj</BaseIntermediateOutputPath>
+    <OutputPath Condition="'$(OutputPath)'=='' ">.\bin\</OutputPath>
+  </PropertyGroup>
+  <PropertyGroup>
+    <SchemaVersion>2.0</SchemaVersion>
+  </PropertyGroup>
+  <ItemGroup>
+    <Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" />
+  </ItemGroup>
+  <Import Project="$(VSToolsPath)\DotNet\Microsoft.DotNet.targets" Condition="'$(VSToolsPath)' != ''" />
+</Project>